[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM (one comment in the test), although it'd be good to get someone more involved in lib/CodeGen to take a quick look / sign off (ideally someone that knows the use case for `!srcloc`...).



================
Comment at: llvm/test/MC/ARM/inline-asm-srcloc.ll:19-24
   call void asm sideeffect " .word -bar", ""() #1, !srcloc !4
 ; CHECK: note: !srcloc = 181
   call void asm sideeffect " .word -foo", ""() #1, !srcloc !5
 ; CHECK: note: !srcloc = 257
+  call void asm sideeffect " .word -stoat", ""() #1, !srcloc !6
+; CHECK: note: !srcloc = 534
----------------
Please add a comment somewhere saying something along the lines of "This tests that both i32 and i64 work, as a proxy for testing that there won't be a crash if old bitcode contains the wrong type" (or anything that will prevent someone from updating the `i32`s to `i64`s as a future cleanup, losing us the test coverage)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105491/new/

https://reviews.llvm.org/D105491