[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

Tue Jul 20 14:12:25 PDT 2021

mibintc added a comment.

In D93769#2891552 <https://reviews.llvm.org/D93769#2891552>, @MaskRay wrote:

> In D93769#2891549 <https://reviews.llvm.org/D93769#2891549>, @mibintc wrote:
>
>> In D93769#2891545 <https://reviews.llvm.org/D93769#2891545>, @MaskRay wrote:
>>
>>> This breaks `clang/test/Index/preamble-reparse-changed-module.m`
>
> Seems like a libclang crash (an `assert` failure) if you enable LLVM_ENABLE_ASSERTIONS=on.
>
> You can reproduce with check-clang-index

Thanks for this, I'm building with assertions on now.  This patch doesn't expand __FLT_EVAL_METHOD__ in -E mode, I'm guessing that's why it fails. It can't expand the macro during -E because the context showing the value of the macro setting is only available in Sema. I haven't yet studied the test but do you know have an idea how I might be able to solve the problem?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93769/new/

https://reviews.llvm.org/D93769