[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

Tomas Matheson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 20 06:26:52 PDT 2021


tmatheson accepted this revision.
tmatheson added a subscriber: efriedma.
tmatheson added a comment.
This revision is now accepted and ready to land.

LGTM, but it would be good to have someone else comment on the increased number of allocations (maybe @rsmith or @efriedma?)



================
Comment at: clang/include/clang/AST/DeclObjC.h:208
   const ParmVarDecl *const *getParams() const {
-    return reinterpret_cast<const ParmVarDecl *const *>(ParamsAndSelLocs);
+    return const_cast<const ParmVarDecl *const *>(Params);
   }
----------------
I don't think you need the `const_cast`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105498/new/

https://reviews.llvm.org/D105498



More information about the cfe-commits mailing list