[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 20 06:01:57 PDT 2021


awarzynski updated this revision to Diff 360100.
awarzynski added a comment.

Switch from `BoolFOption` to `OptInFFlag`/`OptOutFFlag`

I've refactored `OptInFFlag`/`OptOutFFlag` a tiny bit and created specialisations for `clang -cc1` (`OptInCC1FFlag`/`OptOutCC1FFlag`). I have added some comments in Options.td to clarify the semantics of `OptInFFlag`/`OptOutFFlag`. Does this make sense to you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105881/new/

https://reviews.llvm.org/D105881

Files:
  clang/include/clang/Driver/Options.td
  flang/lib/Frontend/CompilerInvocation.cpp
  flang/test/Driver/driver-help-hidden.f90
  flang/test/Driver/driver-help.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105881.360100.patch
Type: text/x-patch
Size: 15454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210720/f2815964/attachment.bin>


More information about the cfe-commits mailing list