[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 19 21:27:27 PDT 2021


efriedma added a comment.

The part I'm most uncomfortable with is sticking "mem2reg" in a public, documented driver option.  I don't want to promise that the mem2reg pass will exist forever.  We should be focused on making sure the options we add are stable, and compose effectively, not just being convenient for some specific use.

I'd be less concerned if it were just a -cc1 option; if it's for our internal use, and we can throw it away if we come up with a better solution, this seems okay.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105516/new/

https://reviews.llvm.org/D105516



More information about the cfe-commits mailing list