[PATCH] D106282: [PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src-compat=mixed`

Amy Kwan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 19 07:57:50 PDT 2021


amyk created this revision.
amyk added reviewers: PowerPC, nemanjai, stefanp.
amyk added projects: LLVM, PowerPC, clang.
Herald added subscribers: shchenz, kbarton.
amyk requested review of this revision.

This patch adds the `-faltivec-src-compat=mixed` option to the `builtins-ppc-altivec.c` test.

Currently, the default for `-faltivec-src-compat` is `mixed`. The reason we explicitly specify `mixed` 
to the RUN lines of this test is because eventually, the default will set to `xl`.

Having the default as `xl` changes the CHECKs of this test slightly, as it reorders some of the
`vector bool` and `vector pixel` CHECKs (since under the `xl` option, `vector bool` and `vector pixel`
are treated in the same way as other vector scalars). Explicitly specifying `mixed` ensures that
we are testing pre-existing Clang behaviour.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106282

Files:
  clang/test/CodeGen/builtins-ppc-altivec.c


Index: clang/test/CodeGen/builtins-ppc-altivec.c
===================================================================
--- clang/test/CodeGen/builtins-ppc-altivec.c
+++ clang/test/CodeGen/builtins-ppc-altivec.c
@@ -1,12 +1,16 @@
 // REQUIRES: powerpc-registered-target
 // RUN: %clang_cc1 -target-feature +altivec -triple powerpc-unknown-unknown -emit-llvm %s \
-// RUN:            -flax-vector-conversions=none -o - | FileCheck %s
+// RUN:            -flax-vector-conversions=none  -faltivec-src-compat=mixed \
+// RUN:            -o - | FileCheck %s
 // RUN: %clang_cc1 -target-feature +altivec -triple powerpcle-unknown-unknown -emit-llvm %s \
-// RUN:            -flax-vector-conversions=none -o - | FileCheck %s -check-prefix=CHECK-LE
+// RUN:            -flax-vector-conversions=none  -faltivec-src-compat=mixed \
+// RUN:            -o - | FileCheck %s -check-prefix=CHECK-LE
 // RUN: %clang_cc1 -target-feature +altivec -triple powerpc64-unknown-unknown -emit-llvm %s \
-// RUN:            -flax-vector-conversions=none -o - | FileCheck %s
+// RUN:            -flax-vector-conversions=none  -faltivec-src-compat=mixed \
+// RUN:            -o - | FileCheck %s
 // RUN: %clang_cc1 -target-feature +altivec -triple powerpc64le-unknown-unknown -emit-llvm %s \
-// RUN:            -flax-vector-conversions=none -o - | FileCheck %s -check-prefix=CHECK-LE
+// RUN:            -flax-vector-conversions=none  -faltivec-src-compat=mixed \
+// RUN:            -o - | FileCheck %s -check-prefix=CHECK-LE
 // RUN: not %clang_cc1 -triple powerpc64le-unknown-unknown -emit-llvm %s \
 // RUN:            -ferror-limit 0 -DNO_ALTIVEC -o - 2>&1 \
 // RUN:            | FileCheck %s -check-prefix=CHECK-NOALTIVEC


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106282.359791.patch
Type: text/x-patch
Size: 1701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210719/620bbb4e/attachment-0001.bin>


More information about the cfe-commits mailing list