[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 16 19:58:22 PDT 2021


NoQ added a comment.

Looks great now!



================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:416
+
+      return "Assuming that stream reaches end-of-file here";
+    });
----------------
The word "that" looks redundant, we don't use it in any other similar notes, eg. "Assuming ~~that~~ 'ptr' is null" etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104925/new/

https://reviews.llvm.org/D104925



More information about the cfe-commits mailing list