[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

Hongtao Yu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 16 14:32:15 PDT 2021


hoy added inline comments.


================
Comment at: clang/test/Driver/pseudo-probe.c:4
 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT
+// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-names %s 2>&1 | FileCheck %s --check-prefix=YESPROBE
+// RUN: %clang -### -fpseudo-probe-for-profiling -fno-unique-internal-linkage-names %s 2>&1 | FileCheck %s --check-prefix=NONAME
----------------
wenlei wrote:
> how do we test unique linkage name is implied with probe on?
These two test lines below corresponding to line 1 in the test, which show that -funique-internal-linkage-names is passed to cc1.

```

// YESPROBE: -fpseudo-probe-for-profiling
// YESPROBE: -funique-internal-linkage-names
```

The change being made here is a driver change, so a driver test should be good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106193/new/

https://reviews.llvm.org/D106193



More information about the cfe-commits mailing list