[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

[Michael Benfield via Phabricator via cfe-commits]

mbenfield added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:15737
+
+    // Fall through to slow path.
+  }
----------------
cjdb wrote:
> This comment is slightly different to the RHS: does that mean that a diagnostic might not be issued?
I just didn't find the extra verbiage helpful. AFAICT this code could be used for purposes other than issuing a diagnostic, and a diagnostic could be issued after following either the fast or slow path, so it didn't make a lot of sense to me. But if you have a different preference for this comment let me know. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104887/new/

https://reviews.llvm.org/D104887