[PATCH] D106184: [BPF] Use elementtype attribute for preserve.array/struct.index intrinsics

Nikita Popov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 16 13:23:11 PDT 2021


nikic added inline comments.


================
Comment at: llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp:303
     CInfo.RecordAlignment =
         DL->getABITypeAlign(CInfo.Base->getType()->getPointerElementType());
     return true;
----------------
I noticed too late that this intrinsic also uses the element type to get the alignment. I'll have to follow up with the same change for this intrinsic.

Though I'm not completely sure if this is actually used, because no tests fail if I replace this with dummy values like 1 or 128.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106184/new/

https://reviews.llvm.org/D106184



More information about the cfe-commits mailing list