[PATCH] D106146: [clang][deps] Separate filesystem caches for minimized and original files

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 16 12:26:16 PDT 2021


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:165
 
-  if (const CachedFileSystemEntry *Entry = getCachedEntry(Filename)) {
+  bool Minimize = !IgnoredFiles.count(Filename) && shouldMinimize(Filename);
+
----------------
Nit: I suggest calling this `ShouldMinimize`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106146/new/

https://reviews.llvm.org/D106146



More information about the cfe-commits mailing list