[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

Denys Petrov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 16 06:38:41 PDT 2021


ASDenysPetrov added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1908-1912
+    // Handle SymbolCast before actual assignment.
+    std::tie(Sym, NewConstraint) =
+        modifySymbolAndConstraints(Sym, NewConstraint);
+    if (!State)
+      return nullptr;
----------------
vsavchenko wrote:
> ASDenysPetrov wrote:
> > vsavchenko wrote:
> > > That's not using `ConstraintAssignor`, you simply put your implementation in here.  That won't do!
> > OK, please tell me how to use it correctly in my case.
> Can you read the comments first and then ask me if you have any specific questions?
I think I did it. Could you please review the changes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103096/new/

https://reviews.llvm.org/D103096



More information about the cfe-commits mailing list