[PATCH] D105703: [hwasan] Use stack safety analysis.

[Vitaly Buka via Phabricator via cfe-commits]

vitalybuka added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Instrumentation/HWAddressSanitizer.h:32
+                                  Triple TargetTriple = {});
   PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
   static bool isRequired() { return true; }
----------------
fmayer wrote:
> vitalybuka wrote:
> > fmayer wrote:
> > > vitalybuka wrote:
> > > > Why not from M.getTargetTriple() ?
> > > Mostly for consistency with the legacy pass. Either way is fine for me though, what do you prefer?
> > I don't know if will cause any issues, but usually most passes get triple from the module.
> > I prefer we stay consistent with the rest of the code if possible.
> > 
> I'll leave it as is, for consistency within this file, as we need to do it this way for the new pass manager.
That's what I don't like, passing Triple from BackendUtil.cpp
I've updated the patch. You can download it with "arc patch D105703"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105703/new/

https://reviews.llvm.org/D105703