[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins
Lei Huang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 15 12:02:53 PDT 2021
lei added inline comments.
================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1569
}
-
----------------
nit: un-related line deletion
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:5449
+ def : Pat<(int_ppc_sthcx xoaddr:$dst, gprc:$A),
+ (STHCX (EXTSH gprc:$A), xoaddr:$dst)>;
+}
----------------
`EXTSH` should not be needed and we should not be using `xoaddr`
================
Comment at: llvm/test/CodeGen/builtins-ppc-xlcompat-move-tofrom-regs.ll:7
+; RUN: llc -verify-machineinstrs -mtriple=powerpc-unknown-aix \
+; RUN: -mcpu=pwr7 < %s | FileCheck %s --check-prefix=CHECK-AIX
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \
----------------
this is confusing... maybe this shouldjust be `CHECK-32BIT`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105946/new/
https://reviews.llvm.org/D105946
More information about the cfe-commits
mailing list