[PATCH] D105930: [PowerPC] Implement XL compact math builtins

Lei Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 15 10:55:06 PDT 2021


lei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3650
+// XL Compat intrinsics.
+def : Pat<(int_ppc_fmsub f64:$A, f64:$B, f64:$C), (FMSUB $A, $B, $C)>;
+def : Pat<(int_ppc_fmsubs f32:$A, f32:$B, f32:$C), (FMSUBS $A, $B, $C)>;
----------------
nemanjai wrote:
> Please review the order of operands carefully here. I believe the order is wrong either for this one or for the VSX version. Double-check all of the others as well please.
I double checked and both seem correct to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105930/new/

https://reviews.llvm.org/D105930



More information about the cfe-commits mailing list