[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

[Mikael Holmén via Phabricator via cfe-commits]

uabelho added a comment.

In D105692#2879983 <https://reviews.llvm.org/D105692#2879983>, @martong wrote:

> In D105692#2879186 <https://reviews.llvm.org/D105692#2879186>, @uabelho wrote:
>
>> Hi,
>>
>> When compiling with gcc I see the following new warnings with this patch:
>>
>>   [4/22] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/RangeConstraintManager.cpp.o
>>   /repo/uabelho/master-github/clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2395:17: warning: 'clang::ento::ProgramStateRef {anonymous}::RangeConstraintManager::setRange(clang::ento::ProgramStateRef, {anonymous}::EquivalenceClass, clang::ento::RangeSet)' defined but not used [-Wunused-function]
>>    2395 | ProgramStateRef RangeConstraintManager::setRange(ProgramStateRef State,
>>         |                 ^~~~~~~~~~~~~~~~~~~~~~
>>   /repo/uabelho/master-github/clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2384:10: warning: 'clang::ento::RangeSet {anonymous}::RangeConstraintManager::getRange(clang::ento::ProgramStateRef, {anonymous}::EquivalenceClass)' defined but not used [-Wunused-function]
>>    2384 | RangeSet RangeConstraintManager::getRange(ProgramStateRef State,
>>         |          ^~~~~~~~~~~~~~~~~~~~~~
>>
>> Will those methods be used or can they be removed?
>
> I think they can be removed, waiting for Valeriy's approval.
> https://reviews.llvm.org/D106063

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105692/new/

https://reviews.llvm.org/D105692