[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 15 02:40:06 PDT 2021


Szelethus updated this revision to Diff 358876.
Szelethus marked 3 inline comments as done.
Szelethus added a comment.

- Change parameter names to highlight that the node at the end of the function call is a `CallExitBegin`.
- Change individual parameter callbacks to the entire call -- if a client knows that they don't want to emit diagnostics for some function, they can early return, instead of early returning for each parameter.
- Fix according to reviewer comments!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105553/new/

https://reviews.llvm.org/D105553

Files:
  clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
  clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105553.358876.patch
Type: text/x-patch
Size: 26066 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210715/f2317b97/attachment-0001.bin>


More information about the cfe-commits mailing list