[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

Thu Jul 15 00:55:39 PDT 2021

balazske marked 4 inline comments as done.
balazske added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:419-421
+  const CheckerNameRef CheckerName;
+  SymbolRef StreamSym;
+  const ExplodedNode *NotePosition;
----------------
balazske wrote:
> NoQ wrote:
> > I guess it's a matter of preference but I really don't understand the need to define a structure when a lambda is sufficient. Lambda is the intended syntax sugar for exactly what you have written.
> The reason is that the `NoteTag` is added at more than one place. And I do not want a function that returns a lambda.
Problem solved: see `constructSetEofNoteTag`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104925/new/

https://reviews.llvm.org/D104925