[PATCH] D105328: [Frontend] Only compile modules if not already finalized

[Ben Barham via Phabricator via cfe-commits]

bnbarham marked an inline comment as done.
bnbarham added inline comments.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:2854
+        bool recompileFinalized =
+            Result == OutOfDate && Capabilities & ARR_OutOfDate &&
+            getModuleManager().getModuleCache().isPCMFinal(F.FileName);
----------------
vsapsai wrote:
> I don't remember recommended LLVM style or if clang-tidy would complain about it but `... & ... && ...` can be unclear regarding the priority of operations. Personally, I would do `(... & ...) && ...` but I don't know what is the rule, so not insisting.
I don't feel particularly strongly about it either way, so have just updated to add the parentheses :).

Also renamed `recompileFinalized` to `recompilingFinalized` as I thought that made more sense after coming back to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105328/new/

https://reviews.llvm.org/D105328