[PATCH] D106027: Allow setting CLANG_LINKS_TO_CREATE to an empty list

Dmitry Kalinkin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 14 17:29:11 PDT 2021


veprbl created this revision.
Herald added a subscriber: mgorny.
veprbl requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

A user might want to redefine CLANG_LINKS_TO_CREATE to an empty list `""`, but such a value would be considered as a `FALSE` by cmake.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106027

Files:
  clang/tools/driver/CMakeLists.txt


Index: clang/tools/driver/CMakeLists.txt
===================================================================
--- clang/tools/driver/CMakeLists.txt
+++ clang/tools/driver/CMakeLists.txt
@@ -58,7 +58,7 @@
 
 add_dependencies(clang clang-resource-headers)
 
-if(NOT CLANG_LINKS_TO_CREATE)
+if(NOT DEFINED CLANG_LINKS_TO_CREATE)
   set(CLANG_LINKS_TO_CREATE clang++ clang-cl clang-cpp)
 endif()
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106027.358789.patch
Type: text/x-patch
Size: 393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210715/f8609a34/attachment.bin>


More information about the cfe-commits mailing list