[PATCH] D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 14 15:06:04 PDT 2021


alexfh added a comment.

In D105890#2873969 <https://reviews.llvm.org/D105890#2873969>, @thakis wrote:

> I think this is incorrect. See D105892 <https://reviews.llvm.org/D105892> and https://reviews.llvm.org/D104915#2873851 . Don't blindly land changes to suppress warnings – the warnings exist to tell us something :)

Indeed, thanks for pointing this out! On the other hand, it may be worth adding this warning with -Werror to the default set or at least enable it when running pre-merge checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105890/new/

https://reviews.llvm.org/D105890



More information about the cfe-commits mailing list