[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

Wed Jul 14 13:18:09 PDT 2021

samitolvanen added a comment.

In D104058#2877631 <https://reviews.llvm.org/D104058#2877631>, @nickdesaulniers wrote:

> Change LGTM, but I don't understand why the following tests are modified:
>
> - llvm/test/ThinLTO/X86/devirt2.ll

This is needed to fix two `missing symbol resolution` errors that are caused by the aliases we added.

> - llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll
> - llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll

And for these, we need to specify a target triple to use module inline assembly. According to pcc, there shouldn't be a real-world situation where the triple is missing, but these two tests don't currently specify one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104058/new/

https://reviews.llvm.org/D104058