[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 14 07:49:03 PDT 2021


JonChesterfield added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:252
+    bool Wave64 = isWave64(DriverArgs, Kind);
+
+    // TODO: There are way too many flags that change this. Do we need to check
----------------
I recognise this comment. Is this a bunch of logic that can be moved into the base class and then called from here and hip?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105981/new/

https://reviews.llvm.org/D105981



More information about the cfe-commits mailing list