[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers
Jon Chesterfield via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 14 06:18:50 PDT 2021
JonChesterfield added inline comments.
================
Comment at: clang/lib/Headers/openmp_wrappers/complex:21
#define __OPENMP_NVPTX__
#include <__clang_cuda_complex_builtins.h>
#undef __OPENMP_NVPTX__
----------------
^ this header does not look for a macro called __CUDA__ or include any other headers so I believe dropping the macro can make no change to that header.
It might affect other things that happen to be included after this header, but iiuc cuda and openmp-nvptx both define `__CUDA__` anyway, so that could only break amdgpu applications that were erroneously looking for a cuda macro.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105221/new/
https://reviews.llvm.org/D105221
More information about the cfe-commits
mailing list