[PATCH] D104420: thread_local support for AIX

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2966
+    // other TUs will not know whether the initialization routine exists
+    // so create a weak, empty, init function to satisfy the linker.
+    // This is needed whenever a thread wrapper function is not used, and
----------------
The linkage of the init function here should not be hard-coded as weak: If the strong definition of the variable has no dynamic initialization/finalization, then the init function the wrapper functions call should resolve to the empty version created here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104420/new/

https://reviews.llvm.org/D104420