[PATCH] D69764: [clang-format] Add East/West Const fixer capability

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 13 10:34:05 PDT 2021


aaron.ballman added a comment.

In D69764#2874464 <https://reviews.llvm.org/D69764#2874464>, @atomgalaxy wrote:

> It's very difficult to use a compile_commands database if you can't
> actually check out all the code and a remote service builds it for you.



In D69764#2874514 <https://reviews.llvm.org/D69764#2874514>, @MyDeveloperDay wrote:

>> FWIW, if you use the compile commands database, the only thing you need to do on the command line is specify the checks to enable or disable.
>
> The project I work on doesn't have/use compile commands databases? if you are make based system or some other legacy build system you just may not have this, so I don't want to limit the uses to just those projects that do.

These are both fair criticisms (that I agree with!). However, adding an entirely new tool is a pretty heavy approach and I think we should only do it when there's a strong use case (and there may be such a strong case in this instance). However, I just now realize that we've added other tools for this sort of thing in the past -- we have `clang-change-namespace` and `clang-reorder-fields` which are not entirely unrelated to this same concept, so there's something like precedent here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764



More information about the cfe-commits mailing list