[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 13 10:32:55 PDT 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Could probably haggle over the tests some more, but might be diminishing returns at this point. Looks good!

Might suggest separating the code cleanup mlir changes from the warning change (committing the warning change first, then as a follow-up committing the mlir change), ideally. Not a huge deal either way - but the usual "separable changes should be separated".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102728/new/

https://reviews.llvm.org/D102728



More information about the cfe-commits mailing list