[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

Tue Jul 13 07:12:07 PDT 2021

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, lgtm!

================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:259

+    class T{$explicit[[]]$constructor[[T]](int a);};
+
----------------
sammccall wrote:
> kadircet wrote:
> > ah, should've kept reading before leaving the comment above. feel free to ignore that (or just drop this test and rely only on clang diagnostics for checking that behaviour?)
> This really belongs in the diagnostic ranges test, so switched to a different diag as you suggested.
nit: is this testing anything useful now? maybe just drop it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105679/new/

https://reviews.llvm.org/D105679