[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options
Pete Steinfeld via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 13 07:02:37 PDT 2021
PeteSteinfeld requested changes to this revision.
PeteSteinfeld added a comment.
This revision now requires changes to proceed.
This built OK, but when I run `check-flang`, I see errors for `.../Driver/driver-help.f90` and `.../Driver/driver-help-hidden.f90`. I'm building on a Linux system using GNU g++ version 9.3. Here's an excerpt from the log file:
FAIL: Flang :: Driver/driver-help.f90 (4 of 712)
******************** TEST 'Flang :: Driver/driver-help.f90' FAILED ********************
Script:
--
: 'RUN: at line 6'; /local/home/psteinfeld/main/andy/flang/build/bin/flang-new -help 2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90 --check-prefix=HELP
: 'RUN: at line 7'; not /local/home/psteinfeld/main/andy/flang/build/bin/flang-new -helps 2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90 --check-prefix=ERROR
: 'RUN: at line 12'; /local/home/psteinfeld/main/andy/flang/build/bin/flang-new -fc1 -help 2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90 --check-prefix=HELP-FC1
: 'RUN: at line 13'; not /local/home/psteinfeld/main/andy/flang/build/bin/flang-new -fc1 -helps 2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90 --check-prefix=ERROR
--
Exit Code: 1
Command Output (stderr):
--
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90:43:14: error: HELP-NEXT: expected string not found in input
! HELP-NEXT: -fno-backslash
^
<stdin>:27:54: note: scanning from here
-flogical-abbreviations Enable logical abbreviations
^
<stdin>:28:2: note: possible intended match here
-fno-color-diagnostics Disable colors in diagnostics
^
Input file: <stdin>
Check file: /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help.f90
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
22: -fimplicit-none No implicit typing allowed unless overridden by IMPLICIT statements
23: -finput-charset=<value> Specify the default character set for source files
24: -fintrinsic-modules-path <dir>
25: Specify where to find the compiled intrinsic modules
26: -flarge-sizes Use INTEGER(KIND=8) for the result type in size-related intrinsics
27: -flogical-abbreviations Enable logical abbreviations
next:43'0 X error: no match found
28: -fno-color-diagnostics Disable colors in diagnostics
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:43'1 ? possible intended match
29: -fopenacc Enable OpenACC
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~
30: -fopenmp Parse OpenMP pragmas and generate parallel code.
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
31: -fxor-operator Enable .XOR. as a synonym of .NEQV.
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
32: -help Display available options
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
33: -I <dir> Add directory to the end of the list of include search paths
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.
.
.
>>>>>>
--
********************
FAIL: Flang :: Driver/driver-help-hidden.f90 (5 of 712)
******************** TEST 'Flang :: Driver/driver-help-hidden.f90' FAILED ********************
Script:
--
: 'RUN: at line 6'; /local/home/psteinfeld/main/andy/flang/build/bin/flang-new --help-hidden 2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90
: 'RUN: at line 7'; not /local/home/psteinfeld/main/andy/flang/build/bin/flang-new -help-hidden 2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90 --check-prefix=ERROR-FLANG
: 'RUN: at line 12'; not /local/home/psteinfeld/main/andy/flang/build/bin/flang-new -fc1 --help-hidden 2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90 --check-prefix=ERROR-FLANG-FC1
: 'RUN: at line 13'; not /local/home/psteinfeld/main/andy/flang/build/bin/flang-new -fc1 -help-hidden 2>&1 | /local/home/psteinfeld/main/clean/install/bin/FileCheck /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90 --check-prefix=ERROR-FLANG-FC1
--
Exit Code: 1
Command Output (stderr):
--
/local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90:43:15: error: CHECK-NEXT: expected string not found in input
! CHECK-NEXT: -fno-backslash
^
<stdin>:27:54: note: scanning from here
-flogical-abbreviations Enable logical abbreviations
^
<stdin>:28:2: note: possible intended match here
-fno-color-diagnostics Disable colors in diagnostics
^
Input file: <stdin>
Check file: /local/home/psteinfeld/main/andy/flang/test/Driver/driver-help-hidden.f90
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
22: -fimplicit-none No implicit typing allowed unless overridden by IMPLICIT statements
23: -finput-charset=<value> Specify the default character set for source files
24: -fintrinsic-modules-path <dir>
25: Specify where to find the compiled intrinsic modules
26: -flarge-sizes Use INTEGER(KIND=8) for the result type in size-related intrinsics
27: -flogical-abbreviations Enable logical abbreviations
next:43'0 X error: no match found
28: -fno-color-diagnostics Disable colors in diagnostics
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:43'1 ? possible intended match
29: -fopenacc Enable OpenACC
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~
30: -fopenmp Parse OpenMP pragmas and generate parallel code.
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
31: -fxor-operator Enable .XOR. as a synonym of .NEQV.
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
32: -help Display available options
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
33: -I <dir> Add directory to the end of the list of include search paths
next:43'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.
.
.
>>>>>>
--
********************
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105881/new/
https://reviews.llvm.org/D105881
More information about the cfe-commits
mailing list