[PATCH] D69764: [clang-format] Add East/West Const fixer capability

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 13 04:25:59 PDT 2021


aaron.ballman added a comment.

In D69764#2873225 <https://reviews.llvm.org/D69764#2873225>, @MyDeveloperDay wrote:

> If this is something we think we wouldn't want in clang-format, what about the idea of building a new binary which did allow the modification of the tokens, This comes up from time to time and I kind of feel its a weak argument for those that don't want to use it enforcing their will on those that do.
>
> I feel we have D69764: [clang-format] Add East/West Const fixer capability <https://reviews.llvm.org/D69764> and D95168: [clang-format] Add InsertBraces option <https://reviews.llvm.org/D95168> both of which seem to break the fundamental belief that some feel that we shouldn't change anything other than whitespace (A fact that has already been broken 3 times already).
>
> But really these are just separate passes, so why couldn't clang-format allow custom passes to be added much like any compiler does.
>
> If the objection is that this isn't clang-format's role then what if we build something new whose purpose IS to allow these kinds of changes?

What you're describing sounds like clang-tidy but perhaps with improved support for composing source modifications from fix-its, or do you envision something rather different?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764



More information about the cfe-commits mailing list