[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

Mon Jul 12 15:53:45 PDT 2021

ZarkoCA marked an inline comment as done.
ZarkoCA added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256
+def warn_not_xl_compatible
+    : Warning<"requested alignment of arguments 16 bytes or greater is not"
+              " compatible with previous versions of the AIX XL compiler">,
+      InGroup<DiagGroup<"builtin-assume-aligned-alignment">>;
----------------
aaron.ballman wrote:
> Should we be talking about the AIX XL compiler in a Clang diagnostic?
I see your point. Sorry if this isn't what is supposed to be done or if it doesn't a good precedent.

The reasons for adding this warning is that our back end implementation isn't totally compatible with XL now and, while buggy, users on AIX may expect clang and xlclang to be compatible since AIX is the reference compiler.  The xlclang name implies it's clang based and it's possible for users to expect some sort of binary compatibility.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105660/new/

https://reviews.llvm.org/D105660