[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

Deep Majumder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 10 07:50:44 PDT 2021


RedDocMD marked 4 inline comments as done.
RedDocMD added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:195
 
+const SmallVector<StringRef, 1> BasicOstreamName = {"basic_ostream"};
+
----------------
vsavchenko wrote:
> Same here + don't call it "Name" (singular).  It is a) an array and b) in the future, we might add more things to it, so we shouldn't need to rename it everywhere.
Well, we won't have to rename but we will still have to change the array length everywhere if more names are added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105421/new/

https://reviews.llvm.org/D105421



More information about the cfe-commits mailing list