[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

Derek Schuff via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 9 16:30:38 PDT 2021


dschuff added inline comments.


================
Comment at: clang/lib/Basic/Targets/WebAssembly.h:175
+    if (T.isOSEmscripten())
+      resetDataLayout("e-m:e-p:32:32-i64:64-f128:64-n32:64-S128-ni:1");
+    else
----------------
kripken wrote:
> Should this not be
> 
> resetDataLayout("e-m:e-p:64:64-i64:64-f128:64-n32:64-S128-ni:1");
> 
> (that is, the first two numbers should be 64?)
oops yes, that's a copypasta


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105749/new/

https://reviews.llvm.org/D105749



More information about the cfe-commits mailing list