[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

Valeriy Savchenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 9 08:09:49 PDT 2021


vsavchenko added a comment.

In D103096#2867136 <https://reviews.llvm.org/D103096#2867136>, @ASDenysPetrov wrote:

> @vsavchenko
>
>> I still want to hear a good explanation why is it done this way.  Here `c` is mapped to `(char)x`, and we have `[-10, 10]` directly associated with it, but we also have `(short)x` associated with `[8, 8]`.  Why can't `VisitSymbolCast` look up constraints for `(short)x` it already looks up for constraints for different casts already.
>
> Hm, you've confused me. I'll make some debugging and report.

It should not be about debugging, it's your code!  Why did you write it this way!?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103096/new/

https://reviews.llvm.org/D103096



More information about the cfe-commits mailing list