[PATCH] D105127: Implement P1401R5

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 9 08:07:17 PDT 2021


aaron.ballman added a comment.

This LGTM aside from a small nit, but you should wait a bit to land in case other reviewers have comments.



================
Comment at: clang/test/CXX/stmt.stmt/stmt.select/stmt.if/p2.cpp:42-43
+
+struct S {
+} s;
   void f() {
----------------
This looks like it still needs some indentation to match the nearby local style. Also, do you need to declare the variable `s`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105127/new/

https://reviews.llvm.org/D105127



More information about the cfe-commits mailing list