[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

[Matheus Izvekov via Phabricator via cfe-commits]

mizvekov added a comment.

In D104500#2863368 <https://reviews.llvm.org/D104500#2863368>, @jyknight wrote:

> This commit seems to have broken libc++ in C++98 mode, as it appears to have depended upon the implicit-move extension.
>
> The root cause appears to be that libc++ emulates unique_ptr in c++98 mode, and this emulation stopped working.

Thank you for the report!

It's not that hard, right now, to put that support back in.
But with C++11 up to C++20 sharing the same code, this is a lot of burden to have yet another implicit move mechanism just for C++98.

AFAIK, rvalue references in C++98 is a clang-only thing, none of the other C++ compilers implement this extension.
And this was also never officially supported, it is a best effort kind of deal.

And I think libc++ is in the process of ditching support for C++98 completely, though I might be mistaken about the extent here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104500/new/

https://reviews.llvm.org/D104500