[PATCH] D105490: Remove unused parameter from parseMSInlineAsm.
Mikhail Maltsev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 8 05:49:46 PDT 2021
miyuki accepted this revision.
miyuki added a comment.
This revision is now accepted and ready to land.
This change is not part of my original D97204 <https://reviews.llvm.org/D97204> patch (in D97204 <https://reviews.llvm.org/D97204>, I replaced `void *AsmLoc` with `uint64_t AsmLoc`), so I think I am eligible to review the change.
This patch is a small NFC refactoring that removes an unused parameter, therefore, simplifies the code. The `parseMSInlineAsm` method doesn't have a GNU counterpart, so changing its prototype doesn't break any consistency. The CI failure `lock-unrelated.c` is, ahem, unrelated (the test does not contain inline assembly).
The patch LGTM, but since Clang isn't our primary area, please wait a few days before committing so that others have time to comment or raise objections.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105490/new/
https://reviews.llvm.org/D105490
More information about the cfe-commits
mailing list