[PATCH] D105526: opencl-c.h: CL3.0 generic address space

[Dave Airlie via Phabricator via cfe-commits]

airlied added inline comments.


================
Comment at: clang/lib/Headers/opencl-c.h:7341
 half8 __ovld fract(half8 x, __private half8 *iptr);
 half16 __ovld fract(half16 x, __private half16 *iptr);
----------------
Anastasia wrote:
> This one is not generic address space pointer though but I think this bit is part of an `#else` block? If you could just re-upload as a full diff, this will make it less confusing to review: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
That's a good point, I was just adding the defined() bits to the endif to match the way other parts are done, however if there is an #else in the middle does this still make sense. I find having the defined comments is helpful for matching up wayward elses. The atomic changes are much more invasive so it would be good to know what we think is correct before I rework them all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105526/new/

https://reviews.llvm.org/D105526