[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 7 13:26:04 PDT 2021


rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: clang/lib/AST/Decl.cpp:2203
       return nullptr;
-    if (Kind == TentativeDefinition)
-      LastTentative = I;
+    // Record the first TentativeDefinition that is encountered.
+    if (Kind == TentativeDefinition && !LastTentative)
----------------
Might help to clarify what we're aiming for?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99732/new/

https://reviews.llvm.org/D99732



More information about the cfe-commits mailing list