[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 7 10:52:19 PDT 2021


aprantl added a comment.

I think it would be best to split out the Clang change into a separately tested patch.



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693
+    if (!try_resolving_type)
+      return true;
+
----------------
This block looks like it's more complicated than it needs to be. Could you just say

```
if (other_die != die)
      if (other_die.Tag()) != DW_TAG_subprogram)
       return false;

```
or am I missing something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105564/new/

https://reviews.llvm.org/D105564



More information about the cfe-commits mailing list