[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

Wed Jul 7 05:59:22 PDT 2021

erichkeane added a comment.

I agree with Aaron for the need of a test.  At one point, we may wish to replace these calls with `getLangOpts().isCompatibleWithMSVC` or some similar inspection of `MSCompatibilityVersion`, but I acknowledge we can't do that until we figure out what the correct version IS!

Otherwise this seems like an appropriate temporary solution.

================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:602
+    if (!LangOpts.MSVCCompat)
+      Builder.defineMacro("__cpp_implicit_move", "202011L");
     Builder.defineMacro("__cpp_size_t_suffix", "202011L");
----------------
This isn't adding a 'tab' character here, is it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105518/new/

https://reviews.llvm.org/D105518