[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

[Vassil Vassilev via Phabricator via cfe-commits]

v.g.vassilev added a comment.

@dexonsmith thanks for doing that cleanup!

I am currently trying to rebase https://reviews.llvm.org/D33275 on top of our internal infrastructure. We (cling) use `SourceManager::overrideFileContents` to provide virtual file content. It seems that every call to `ContentCache::getBufferOrNone` should somehow consider if the content was not overridden. Do you see an easy way to get D33275 <https://reviews.llvm.org/D33275> aligned to `LineOffsetMapping`? Alternatively, we could require a `SourceManager&` argument to `ContentCache::getBufferOrNone` and return the overridden buffer...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89913/new/

https://reviews.llvm.org/D89913