[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/tools/libclang/CMakeLists.txt:82
+
+if (LLVM_EXPORTED_SYMBOL_FILE)
+  add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE}
----------------
What does this do?

A hard-coded list cannot catch up with the real dynamic symbol list. We'll have to parse llvm-readelf --dyn-syms output...


================
Comment at: clang/tools/libclang/libclang.map:405
+    clang_visitChildrenWithBlock;
+local: *;
+};
----------------
Make its indentation match `global:`


================
Comment at: clang/tools/libclang/libclang.map:413
+ *    clang_newsymbol;
+ * } LLVM_13;
+ */
----------------
The dependency syntax is completely ignored by LLD and GNU ld.

Having it can only cause confusion.


================
Comment at: clang/tools/libclang/linker-script-to-export-list.py:10
+    if m:
+        output_file.write(m.group(0)
----------------
syntax error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105527/new/

https://reviews.llvm.org/D105527