[PATCH] D105497: [clang] Serialize source locations as 64-bit in PCH.

Simon Tatham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 6 09:27:50 PDT 2021


simon_tatham created this revision.
simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi.
simon_tatham requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This is part of a patch series working towards the ability to make
SourceLocation into a 64-bit type to handle larger translation units.

Unconditionally expanding the serialized encoding to 64 bits is the
simplest way to ensure that it will be big enough to handle an
expanded SourceLocation.

As I understand it, PCH files are already automatically versioned with
the exact revision of the compiler that built them, so this shouldn't
introduce any compatibility problem, because clang will already refuse
to load any PCH from a different version of itself.

Patch based on previous work by Mikhail Maltsev.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105497

Files:
  clang/include/clang/Serialization/ASTReader.h
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTWriter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105497.356763.patch
Type: text/x-patch
Size: 5084 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210706/d2a3efb1/attachment.bin>


More information about the cfe-commits mailing list