[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

Manas Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 6 04:17:43 PDT 2021


manas added inline comments.


================
Comment at: clang/utils/analyzer/entrypoint.py:12
     settings, rest = parse_arguments()
+    cmake_opts = list(filter(lambda cmd: cmd[:2]=='-D', rest))
     if settings.wait:
----------------
vsavchenko wrote:
> I think we should still use `argparse` for stuff like this, and we don't want any of these flags to sneak into `rest`.
> https://stackoverflow.com/a/31141568/11582326
Understood! I will rework on this. Thanks for the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105447/new/

https://reviews.llvm.org/D105447



More information about the cfe-commits mailing list