[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

Christopher Di Bella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 5 10:11:11 PDT 2021


cjdb added a comment.

A few notes to reviewers:

- The patch assumes everything is under a top-level `__libcxx` directory, because it seems there are other system headers that could be prefixed with `__`. libc++ currently has many top-level directories, following the trend of `__${STD_LIB_HEADER}/`. I see two solutions going forward:
  1. libc++ moves everything into a top-level `__libcxx` directory, which minimises the chances of clashing with pre-existing top-level directories that we don't own. Once this patch is committed, it probably won't need to be updated (sans bug fixes).
  2. This patch adopts a set of "blessed" directories that needs to be consistently updated as we splice more and more headers (and as WG21 adds more headers to C++).
- The patch could probably do with more testing, but I'm coming up dry :-(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105439/new/

https://reviews.llvm.org/D105439



More information about the cfe-commits mailing list