[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

Shivam Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 4 21:18:46 PDT 2021


xgupta added subscribers: MyDeveloperDay, xgupta.
xgupta added a reviewer: MyDeveloperDay.
xgupta added a comment.

Thanks for the patch @Et7f3! I tested it locally and can reproduce it with cat folder/file.c
int main()
{
return 0;
}
And indeed the patch also solved the crash issue and emit a correct error message but I am not sure about its implementation, I think @MyDeveloperDay can best review this patch.

There is a nit in the patch summary, `clang-format -i root/file.c` should be `clang-format -i folder/file.c`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105408/new/

https://reviews.llvm.org/D105408



More information about the cfe-commits mailing list