[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 2 14:42:06 PDT 2021


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

I'm happy with this.



================
Comment at: compiler-rt/include/profile/InstrProfData.inc:79
+INSTR_PROF_DATA(const IntPtrT, IntPtrTy, CounterPtr,
+                ConstantExpr::getSub(ConstantExpr::getPtrToInt(CounterPtr,
+                                                               IntPtrTy),
----------------
I'd suggest moving this into a local variable in the instrumentation code. The less code there is in this header, the better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104556/new/

https://reviews.llvm.org/D104556



More information about the cfe-commits mailing list