[PATCH] D105368: Lex: add a callback for `#pragma mark`

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 2 14:04:09 PDT 2021


dgoldman added inline comments.


================
Comment at: clang/unittests/Lex/PPCallbacksTest.cpp:119
+    SourceLocation Location;
+    StringRef Trivia;
+  };
----------------
should this be an std::string? not sure of the lifetime guarantees here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105368/new/

https://reviews.llvm.org/D105368



More information about the cfe-commits mailing list