[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

Fri Jul 2 09:10:24 PDT 2021

craig.topper added inline comments.

================
Comment at: llvm/lib/Target/X86/X86Subtarget.h:748
   bool hasVLX() const { return HasVLX; }
+  bool hasFP16() const { return HasFP16; }
   bool hasPKU() const { return HasPKU; }
----------------
pengfei wrote:
> RKSimon wrote:
> > I'm a little worried this might get confused with hasF16C - am I just being over cautious?
> Make sense. How about `hasAVX512FP16`? I can update the name as a followup patch once these patches merged.
That sounds good to me. We should maybe go back and update some of the others. Especially VNNI since we also have AVXVNNI.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105263/new/

https://reviews.llvm.org/D105263